https://bugzilla.redhat.com/show_bug.cgi?id=871092

--- Comment #6 from Antonio Trande <trp...@katamail.com> ---
(In reply to comment #4)
> (In reply to comment #1)
> 
> > You have to write the BuildRequires like that:
> > BuildRequires: pkgconfig, gettext, ..., ..., ...
> 
> It doesn't matter if one uses one line or several lines.
> 
> However there are at least two problems with this package. Benedikt, please
> look a little closer at the %files section, maybe you find them. ;)
> 

Maybe I'm able to find them :).

1) On the Packaging:Guidelines wiki I read:

>... desktop-file-install MUST be used if the package does not install the file 
>or >there are changes desired to the .desktop file 

so maybe I must also add 'desktop-file-install' apart from
'desktop-file-check'.

2) I don't know if the %post %postun scriptlet are necessary in this case.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to