https://bugzilla.redhat.com/show_bug.cgi?id=870522
--- Comment #2 from Jerry James <loganje...@gmail.com> ---
Thanks for the comments, Ivan.
(In reply to comment #1)
> Drop BR ocaml (ocaml-ocamldoc will pull it when building)
It is redundant, true, but I prefer to keep that particular BR since this is an
ocaml package, so having an explicit BR on the package that provides the
compiler and runtime seems like a good thing to me.
> Ise %{?_isa} for devel subpackage
> https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/
> Guidelines#Requiring_Base_Package
Good catch. I have fixed this.
> static library must be in static subpackage
> https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/
> Guidelines#Packaging_Static_Libraries
Except for the case of OCaml packages. See
https://fedoraproject.org/wiki/Packaging:OCaml, and the section entitled
"-devel subpackage" in particular.
New URLs:
http://jjames.fedorapeople.org/ocaml-zarith/ocaml-zarith.spec
http://jjames.fedorapeople.org/ocaml-zarith/ocaml-zarith-1.1-2.fc19.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
