Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=876645

Eduardo Echeverria <echevemas...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |echevemas...@gmail.com

--- Comment #1 from Eduardo Echeverria <echevemas...@gmail.com> ---
Hi Pádraig
Initial Comments:
- BuildRequires:  python-devel
You must specify if you use python2-devel and python3-devel, python2-devel in
this case.
http://fedoraproject.org/wiki/Packaging:Python#BuildRequires

- Requires: python-testtools >= 0.9.12
the latest version of python-testtools is python-testtools-0.9.21
So no need to specify the version in this case
http://koji.fedoraproject.org/koji/packageinfo?packageID=11850

- License: ASL 2.0 and BSD
the license field should be 
- License: ASL 2.0 or BSD
the author specifies:

"Fixtures is licensed under two licenses, the Apache License, Version 2.0
or the 3-clause BSD License. You may use this project under either of these
licenses - choose the one that works best for you"

Please include in the %doc section the files:
Apache-2.0
BSD
COPYING 

Regards

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to