Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=879879
Bug ID: 879879
Summary: Review Request: moodle-xs - A Course Management System
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: unspecified
Reporter: kparm...@myseneca.ca
Spec URL: https://www.dropbox.com/s/1nueeablnrknpta/moodle-xs.spec
SRPM URL:
https://www.dropbox.com/s/yorim1esj855tac/moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.src.rpm
Description: Hi, I have rebuild this package to meet Fedora Packaging
Guidelines and require a review. I obtained the original package from
build.laptop.org.au/xs/XS-0.7+/repos/XS-F17ARM/SRPMS/moodle-xs-1.9.5.xs1.15.g7c6a865-1.fc17.src.rpm.
There is a problem with this package. Every time I build the package using
rpmbuild command, it supposed to create a directory in /var but it doesn't. The
full path of the directory supposed to be created is in first two lines of the
spec file in define tag. I am not sure why it is behaving like that. I have run
fedora-review tool on it.
Fedora Account System Username: kparmar4
Output of Fedora-Review Tool:
Package Review
==============
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
[!]: Package does not generate any conflict.
Note: Package contains Conflicts: tag(s) needing fix or justification.
See: http://fedoraproject.org/wiki/Packaging/Guidelines#Conflicts
[!]: Package does not contain duplicates in %files.
Note: warning: File listed twice: /var/www/moodle/web/config.php
See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles
[!]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
Note: These BR are not needed: unzip
See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
[!]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
Note: Cannot find COPYING in rpm(s)
See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
===== MUST items =====
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[ ]: %build honors applicable compiler flags or justifies otherwise.
[!]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
Note: These BR are not needed: unzip
[ ]: Package contains no bundled libraries.
[ ]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[ ]: Sources contain only permissible code or content.
[x]: %config files are marked noreplace or the reason is justified.
[ ]: Each %files section contains %defattr if rpm < 4.4
Note: %defattr present but not needed
[ ]: Macros in Summary, %description expandable at SRPM build time.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package requires other packages for directories it uses.
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package is not known to require ExcludeArch.
[!]: Package does not contain duplicates in %files.
Note: warning: File listed twice: /var/www/moodle/web/config.php
[x]: Permissions on files are set properly.
[ ]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[!]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
Note: Cannot find COPYING in rpm(s)
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"GPL", "*No copyright* GPL (v2 or later) (with incorrect FSF address)",
"LGPL (v2.1 or later) (with incorrect FSF address)", "GPL (v2 or later)",
"PHP (v3.0)", "Unknown or generated", "*No copyright* BSD (2 clause)",
"*No copyright* GPL (v3 or later)", "PHP (v2.0)", "*No copyright* Public
domain", "MIT/X11 (BSD like)", "LGPL (v3 or later)", "PHP (v2.02)", "BSD
(2 clause)", "LGPL (v2.1 or later)", "PHP (v3.01)". 16 files have unknown
license. Detailed output of licensecheck in /home/kparmar4/rpmbuild/SRPMS
/review-moodle-xs/licensecheck.txt
[ ]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named using only allowed ASCII characters.
[ ]: Package is named according to the Package Naming Guidelines.
[x]: No %config files under /usr.
[!]: Package does not generate any conflict.
Note: Package contains Conflicts: tag(s) needing fix or justification.
[x]: Package do not use a name that already exist
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Package must own all directories that it creates.
[ ]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[ ]: Package is not relocatable.
[ ]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[ ]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[ ]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[ ]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Perl:
[ ]: Package contains the mandatory BuildRequires and Reguires:.
Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version)) missing?
[ ]: CPAN urls should be non-versioned.
Note: Test run failed
===== SHOULD items =====
Generic:
[x]: Reviewer should test that the package builds in mock.
[ ]: Buildroot is not present
Note: Buildroot: present but not needed
[ ]: Avoid bundling fonts in non-fonts packages.
Note: Package contains font files
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[ ]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[ ]: Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[x]: The placement of pkgconfig(.pc) files are correct.
[ ]: Scriptlets must be sane, if used.
[ ]: SourceX tarball generation or download is documented.
Note: Package contains tarball without URL, check comments
[x]: SourceX / PatchY prefixed with %{name}.
[x]: SourceX is a working URL.
[ ]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed files.
[!]: Spec use %global instead of %define.
Note: %define moodlewebdir %{_var}/www/moodle/web %define moodledatadir
%{_var}/lib/moodle %define __perl_requires %{nil} %define __perl_provides
%{nil}
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
arched.
Rpmlint
-------
Checking: moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.noarch.rpm
moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.src.rpm
moodle-xs.noarch: E: explicit-lib-dependency librsvg2
moodle-xs.noarch: E: useless-provides moodle-xs
moodle-xs.noarch: E: zero-length
/var/www/moodle/web/theme/chameleon/temp_user_styles.css
moodle-xs.noarch: E: zero-length
/var/www/moodle/web/theme/chameleon/pix/mod/index.html
moodle-xs.noarch: E: zero-length /var/www/moodle/web/pix/t/TINY-ICONS
moodle-xs.noarch: E: incorrect-fsf-address
/var/www/moodle/web/lib/phpmailer/LICENSE
moodle-xs.noarch: E: script-without-shebang
/var/www/moodle/web/lib/editor/htmlarea/plugins/SpellChecker/spell-check-logic.cgi
moodle-xs.noarch: E: incorrect-fsf-address
/var/www/moodle/web/lib/smarty/COPYING.lib
moodle-xs.noarch: E: incorrect-fsf-address
/var/www/moodle/web/lib/pclzip/gnu-lgpl.txt
moodle-xs.noarch: E: incoherent-logrotate-file /etc/logrotate.d/moodle
moodle-xs.noarch: E: zero-length
/var/www/moodle/web/lib/editor/htmlarea/index.html
moodle-xs.noarch: E: zero-length
/var/www/moodle/web/lib/typo3/csconvtbl/ascii.tbl
moodle-xs.noarch: E: zero-length /var/www/moodle/web/mod/index.html
moodle-xs.noarch: E: zero-length /var/www/moodle/web/lib/adodb/index.html
moodle-xs.noarch: E: incorrect-fsf-address
/var/www/moodle/web/lib/editor/tinymce/jscripts/tiny_mce/license.txt
moodle-xs.noarch: E: incorrect-fsf-address
/var/www/moodle/web/mod/wiki/ewiki/plugins/lib/mime_magic.php
moodle-xs.noarch: E: zero-length
/var/www/moodle/web/theme/chameleon/pix/i/ICONS-16x16
moodle-xs.noarch: E: zero-length /var/www/moodle/web/lib/speller/blank.html
moodle-xs.noarch: E: incorrect-fsf-address
/var/www/moodle/web/lib/soap/nusoap.php
moodle-xs.noarch: E: zero-length /var/www/moodle/web/auth/index.html
moodle-xs.noarch: E: zero-length /var/www/moodle/web/lib/editor/index.html
moodle-xs.noarch: E: zero-length /var/www/moodle/web/pix/i/ICONS-16x16
moodle-xs.noarch: E: incorrect-fsf-address /var/www/moodle/web/lib/kses.php
moodle-xs.noarch: E: incorrect-fsf-address /var/www/moodle/web/lib/graphlib.php
moodle-xs.noarch: E: non-executable-script
/var/www/moodle/web/admin/mailout-debugger.php 0644L /usr/bin/php
moodle-xs.noarch: E: zero-length
/var/www/moodle/web/theme/chameleon/pix/t/TINY-ICONS
moodle-xs.noarch: W: no-manual-page-for-binary moodle-cron
moodle-xs.noarch: W: dangerous-command-in-%post chmod
moodle-xs.noarch: W: missing-lsb-keyword Default-Stop in
/etc/rc.d/init.d/moodle
moodle-xs.noarch: W: incoherent-init-script-name moodle ('moodle-xs',
'moodle-xsd')
moodle-xs.src: W: invalid-url Source0: moodle-xs-1.9.5.xs1.15.g7c6a865.tar.gz
2 packages and 0 specfiles checked; 26 errors, 5 warnings.
Rpmlint (installed packages)
----------------------------
# rpmlint moodle-xs
moodle-xs.noarch: E: explicit-lib-dependency librsvg2
moodle-xs.noarch: E: useless-provides moodle-xs
moodle-xs.noarch: E: zero-length
/var/www/moodle/web/theme/chameleon/temp_user_styles.css
moodle-xs.noarch: E: zero-length
/var/www/moodle/web/theme/chameleon/pix/mod/index.html
moodle-xs.noarch: E: zero-length /var/www/moodle/web/pix/t/TINY-ICONS
moodle-xs.noarch: E: incorrect-fsf-address
/var/www/moodle/web/lib/phpmailer/LICENSE
moodle-xs.noarch: E: script-without-shebang
/var/www/moodle/web/lib/editor/htmlarea/plugins/SpellChecker/spell-check-logic.cgi
moodle-xs.noarch: E: incorrect-fsf-address
/var/www/moodle/web/lib/smarty/COPYING.lib
moodle-xs.noarch: E: incorrect-fsf-address
/var/www/moodle/web/lib/pclzip/gnu-lgpl.txt
moodle-xs.noarch: E: incoherent-logrotate-file /etc/logrotate.d/moodle
moodle-xs.noarch: E: zero-length
/var/www/moodle/web/lib/editor/htmlarea/index.html
moodle-xs.noarch: E: zero-length
/var/www/moodle/web/lib/typo3/csconvtbl/ascii.tbl
moodle-xs.noarch: E: zero-length /var/www/moodle/web/mod/index.html
moodle-xs.noarch: E: zero-length /var/www/moodle/web/lib/adodb/index.html
moodle-xs.noarch: E: incorrect-fsf-address
/var/www/moodle/web/lib/editor/tinymce/jscripts/tiny_mce/license.txt
moodle-xs.noarch: E: incorrect-fsf-address
/var/www/moodle/web/mod/wiki/ewiki/plugins/lib/mime_magic.php
moodle-xs.noarch: E: zero-length
/var/www/moodle/web/theme/chameleon/pix/i/ICONS-16x16
moodle-xs.noarch: E: zero-length /var/www/moodle/web/lib/speller/blank.html
moodle-xs.noarch: E: incorrect-fsf-address
/var/www/moodle/web/lib/soap/nusoap.php
moodle-xs.noarch: E: zero-length /var/www/moodle/web/auth/index.html
moodle-xs.noarch: E: zero-length /var/www/moodle/web/lib/editor/index.html
moodle-xs.noarch: E: zero-length /var/www/moodle/web/pix/i/ICONS-16x16
moodle-xs.noarch: E: incorrect-fsf-address /var/www/moodle/web/lib/kses.php
moodle-xs.noarch: E: incorrect-fsf-address /var/www/moodle/web/lib/graphlib.php
moodle-xs.noarch: E: non-executable-script
/var/www/moodle/web/admin/mailout-debugger.php 0644L /usr/bin/php
moodle-xs.noarch: E: zero-length
/var/www/moodle/web/theme/chameleon/pix/t/TINY-ICONS
moodle-xs.noarch: W: no-manual-page-for-binary moodle-cron
moodle-xs.noarch: W: dangerous-command-in-%post chmod
moodle-xs.noarch: W: missing-lsb-keyword Default-Stop in
/etc/rc.d/init.d/moodle
moodle-xs.noarch: W: incoherent-init-script-name moodle ('moodle-xs',
'moodle-xsd')
1 packages and 0 specfiles checked; 26 errors, 4 warnings.
# echo 'rpmlint-done:'
Requires
--------
moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.noarch.rpm (rpmlib, GLIBC filtered):
/bin/bash
/bin/sh
/sbin/chkconfig
/sbin/service
/usr/bin/perl
/usr/bin/php
config(moodle-xs) = 1.9.5.xs1.15.g7c6a865-1.0.2.fc17
librsvg2
mimetex
perl(CGI)
perl(Encode)
perl(HTML::Entities)
perl(HTML::Parser)
perl(Text::Aspell)
perl(lib)
php
php-gd
php-mbstring
php-pgsql
php-xmlrpc
pwgen
vixie-cron
Provides
--------
moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.noarch.rpm:
config(moodle-xs) = 1.9.5.xs1.15.g7c6a865-1.0.2.fc17
moodle-xs = 1.9.0
moodle-xs = 1.9.5.xs1.15.g7c6a865-1.0.2.fc17
perl(AlgParser)
perl(AlgParserWithImplicitExpand)
perl(Expr)
perl(ExprWithImplicitExpand)
MD5-sum check
-------------
Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
Buildroot used: fedora-17-i386
Command line :/usr/bin/fedora-review --rpm-spec --name
moodle-xs-1.9.5.xs1.15.g7c6a865-1.0.2.fc17.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
