Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=886022
Parag AN(पराग) <panem...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Flags| |fedora-review?
--- Comment #1 from Parag AN(पराग) <panem...@gmail.com> ---
Review:-
+ Package build fine in mock
+ rpmlint on rpms gave
pyzy-devel.x86_64: W: no-documentation
pyzy-devel.x86_64: E: incorrect-fsf-address /usr/include/pyzy-1.0/PyZy/Const.h
pyzy-devel.x86_64: E: incorrect-fsf-address
/usr/include/pyzy-1.0/PyZy/InputContext.h
pyzy-devel.x86_64: E: incorrect-fsf-address
/usr/include/pyzy-1.0/PyZy/Variant.h
pyzy.src: W: summary-ended-with-dot C The Chinese PinYin and Bopomofo
conversion library.
pyzy.src:35: W: unversioned-explicit-provides pyzy-db
pyzy.src:45: W: unversioned-explicit-provides pyzy-db
pyzy.src: W: invalid-url Source1:
http://pyzy.googlecode.com/files/pyzy-database-1.0.0.tar.bz2 HTTP Error 404:
Not Found
pyzy.src: W: invalid-url Source0:
http://pyzy.googlecode.com/files/pyzy-0.1.0.tar.gz HTTP Error 404: Not Found
pyzy-db-android.noarch: W: no-documentation
pyzy-db-open-phrase.noarch: W: no-documentation
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/BopomofoContext.h
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/FullPinyinContext.h
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/PhoneticContext.cc
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/SpecialPhraseTable.cc
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/PinyinArray.h
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/SimpTradConverterTable.h
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/BopomofoKeyboard.h
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/DoublePinyinContext.cc
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/Bopomofo.h
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/FullPinyinContext.cc
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/PhoneticContext.h
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/DoublePinyinContext.h
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/SimpTradConverter.cc
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/Util.h
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/SpecialPhrase.h
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/PinyinContext.h
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/BopomofoContext.cc
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/PinyinContext.cc
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/PinyinParserTable.h
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/String.h
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/DynamicSpecialPhrase.h
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/DynamicSpecialPhrase.cc
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/SimpTradConverter.h
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/Database.cc
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/Database.h
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/PhraseEditor.h
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/Variant.h
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/PhraseArray.h
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/SpecialPhraseTable.h
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/PinyinParser.h
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/Phrase.h
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/Config.h
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/PinyinParser.cc
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/InputContext.h
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/InputContext.cc
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/PhraseEditor.cc
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/DoublePinyinTable.h
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/Variant.cc
pyzy-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/pyzy-0.1.0/src/Types.h
pyzy.x86_64: W: summary-ended-with-dot C The Chinese PinYin and Bopomofo
conversion library.
pyzy.x86_64: E: library-without-ldconfig-postin
/usr/lib64/libpyzy-1.0.so.0.100.0
pyzy.x86_64: E: library-without-ldconfig-postun
/usr/lib64/libpyzy-1.0.so.0.100.0
6 packages and 0 specfiles checked; 44 errors, 9 warnings.
+ Source verified with upstream as
http://pyzy.googlecode.com/files/pyzy-0.1.0.tar.gz :
CHECKSUM(SHA256) this package :
fe468a4372473d85a56f05d55b14f0e0201fde6f9336a1a2322cf79421c84d9a
CHECKSUM(SHA256) upstream package :
fe468a4372473d85a56f05d55b14f0e0201fde6f9336a1a2322cf79421c84d9a
http://pyzy.googlecode.com/files/pyzy-database-1.0.0.tar.bz2 :
CHECKSUM(SHA256) this package :
32c7d07b9f41e1dfc0f9008f54eca8e6cb367e7f2b19ac94c49754442694c321
CHECKSUM(SHA256) upstream package :
32c7d07b9f41e1dfc0f9008f54eca8e6cb367e7f2b19ac94c49754442694c321
+ license is valid and its text is included
issues:
1) why do you provide same Provides: pyzy-db by 2 subpackages?
2) cp commands should preserve file timestamp using "cp -p" command
3) make install command should preserve timestamp using
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
4) %defattr either be kept for all %files or removed from everywhere.
5) Summary should not end with dot
6) contact upstream to change incorrect fsf address.
7) you missed
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Shared_libraries
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=NcSAmUP1uy&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
