Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=823338
--- Comment #6 from Vít Ondruch <vondr...@redhat.com> ---
Jonas, first of all, have you considered to replace moneta by juno [1] or
something similar? I would say that this package is unmaintained by upstream
and should not get into Fedora.
Otherwise, a few comments:
* Please drop the "Requires: ruby"
- Since we are going to share gems between JRuby and Ruby in F19, it would
pull in MRI even if not needed.
* Test suite
- I guess the test suite was developed for RSpec 1.x while you are trying to
run it with RSpec 2.x. The shared examples are typically troublesome.
- I am not going to dig more into it, but would you please mind to keep the
disabled %check section with appropriate comment in .spec file? It would
help during future updates (if there every will be some) to easily
uncomment
and see what is the state of test suite.
[1] https://github.com/minad/juno
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=8OZEahKBWQ&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
