Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=888301
Antonio Trande <trp...@katamail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |trp...@katamail.com
--- Comment #1 from Antonio Trande <trp...@katamail.com> ---
Hi Sebastien.
I'm not an official packager/reviewer; I'm just doing few comments.
Although this is your first package, it is already good in my opinion.
- You should pick a style and use it consistently throughout your packaging so
install -m 755 -d %{buildroot}%{_mandir}/man1 becomes install -m 755 -d
$RPM_BUILD_ROOT%{_mandir}/man1
and so on.
https://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS
- BuildRequires: systemd-units
On Fedora 18 and newer, the systemd-units subpackage has been merged into the
base systemd package, so your package for those targets can instead include.
Fedora 18 is almost among us, maybe you could use DisTag to mark this requires
entry depending on Fedora release.
https://fedoraproject.org/wiki/Packaging:DistTag?rd=DistTag
https://fedoraproject.org/wiki/Packaging:Systemd?rd=Packaging:Guidelines:Systemd#Filesystem_locations
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=ffTAyZqFAC&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
