Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=888224
Antonio Trande <trp...@katamail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |trp...@katamail.com
--- Comment #1 from Antonio Trande <trp...@katamail.com> ---
Hi Lorenzo.
Just some initial comments.
- I have some dubious about its license; it seems a MIT
- Source0 should indicate an entire link to the source package or how it has
been created.
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL
- Description is not correct in my opinion. Better:
'This program emulates an AirPort Express for the purpose of streaming music
from iTunes and compatible iPods. It implements a server for the Apple RAOP
protocol.
ShairPort does not support AirPlay v2 (video and photo streaming).
It supports multiple simultaneous streams, if your audio output chain (as
detected by libao) does so'
- This line 'rm -rf $RPM_BUILD_ROOT' can be omitted
- %doc line is empty. Why ?
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=hfyZWbFIBP&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
