Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=888224
--- Comment #11 from Lorenzo Dalrio <lorenzo.dal...@gmail.com> --- Hi Ken, thank you. > The first thing is that rpmlint caught an unnecessary link in > libshairport.so.2.0.0. I have included your patch in the package and proposed it upstream too: https://github.com/amejia1/libshairport/pull/3 If it will be included upstream i will remove it from package. > The second thing is that the -devel subpackage contains two files that are > unnecessary. Files removed. > The third thing is that the Summary: field should be capitalized, so change > "emulates" to "Emulates". Done. > The fourth thing is that rpmlint complains about permissions on the > generate-tarball script. Permissions changed. > The fifth thing is that rpmlint complains using %define instead of %global. Changed from %define to %global. Hi Michael, > It's possible to omit the Group tag, but if it's filled in, base libraries > enter group "System Environment/Libraries". Only the corresponding -devel > package enters group "Development/Libraries". I have corrected groups membership. > "Requires: libao-devel%{?_isa}" is missing, because the libshairport header > includes "ao" headers. Requires added. > is an ALAC decoder from 2005. What's the current legal situation here with > regard to Apple having published their codec as Open Source Software last > year? I don't know about this, can anyone help? New spec and srpm versions: Spec URL: http://lorenzodalrio.fedorapeople.org/libshairport.spec SRPM URL: http://lorenzodalrio.fedorapeople.org/libshairport-1.2.1-2.20121218git16395d8.fc17.src.rpm Successful koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4826859 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ixQrDAiVtD&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
