Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891237
Miro Hrončok <mhron...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |needinfo?(tchollingsworth@g
| |mail.com)
--- Comment #1 from Miro Hrončok <mhron...@redhat.com> ---
Description and Summary are OK.
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
$ rpmlint ../SRPMS/nodejs-slide-1.1.3-3.fc18.src.rpm
../RPMS/noarch/nodejs-slide-1.1.3-3.fc18.noarch.rpm
nodejs-slide.src: W: spelling-error Summary(en_US) slideshow -> sideshow, slide
show, slide-show
nodejs-slide.src: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-slide.src: W: no-%build-section
nodejs-slide.noarch: W: spelling-error Summary(en_US) slideshow -> sideshow,
slide show, slide-show
nodejs-slide.noarch: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-slide.noarch: W: only-non-binary-in-usr-lib
2 packages and 0 specfiles checked; 0 errors, 6 warnings.
FIX: Add an empty %build section
Other issues are false positive.
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. OK
MUST: The package must meet the Packaging Guidelines. OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines.
MUST: The License field in the package spec file must match the actual license.
There is no license statement in the tarball. However I can see it on GitHub
https://raw.github.com/isaacs/slide-flow-control/master/LICENSE
FIX: Add statement about the LICENSE in future release (as you did in
nodejs-promzard)
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc. OK
MUST: The spec file must be written in American English. OK
MUST: The spec file for the package MUST be legible. OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use sha256sum for this task as it is
used by the sources file once imported into git.
$ sha256sum ../SOURCES/slide-1.1.3.tgz
80c07458031e72640a5cf0abe8825e8c33ef00a0326217ae7c1c59494ee96e04
../SOURCES/slide-1.1.3.tgz
$ wget -q http://registry.npmjs.org/slide/-/slide-1.1.3.tgz
$ sha256sum slide-1.1.3.tgz
80c07458031e72640a5cf0abe8825e8c33ef00a0326217ae7c1c59494ee96e04
slide-1.1.3.tgz
OK
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. OK
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense. OK, builds
in mock
MUST: Packages must NOT bundle copies of system libraries. OK
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory. OK
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. OK
MUST: Permissions on files must be set properly.
$ rpm -q -lv -p ../RPMS/noarch/nodejs-slide-1.1.3-3.fc18.noarch.rpm
drwxr-xr-x 2 root root 0 led 9 11:46
/usr/lib/node_modules/slide
drwxr-xr-x 2 root root 0 led 9 11:46
/usr/lib/node_modules/slide/lib
-rw-r--r-- 1 root root 1729 čec 27 2011
/usr/lib/node_modules/slide/lib/async-map-ordered.js
-rw-r--r-- 1 root root 1496 čec 27 2011
/usr/lib/node_modules/slide/lib/async-map.js
-rw-r--r-- 1 root root 382 čec 27 2011
/usr/lib/node_modules/slide/lib/bind-actor.js
-rw-r--r-- 1 root root 660 čec 27 2011
/usr/lib/node_modules/slide/lib/chain.js
-rw-r--r-- 1 root root 121 čec 27 2011
/usr/lib/node_modules/slide/lib/slide.js
drwxr-xr-x 2 root root 0 led 9 11:46
/usr/lib/node_modules/slide/node_modules
-rw-r--r-- 1 root root 520 čec 27 2011
/usr/lib/node_modules/slide/package.json
drwxr-xr-x 2 root root 0 led 9 11:46
/usr/share/doc/nodejs-slide-1.1.3
-rw-r--r-- 1 root root 733 čec 27 2011
/usr/share/doc/nodejs-slide-1.1.3/README.md
-rw-r--r-- 1 root root 167502 čec 27 2011
/usr/share/doc/nodejs-slide-1.1.3/nodejs-controlling-flow.pdf
OK
MUST: Each package must consistently use macros. OK
MUST: The package must contain code, or permissable content. OK
MUST: If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is in %doc, the program must run
properly if it is not present. OK
MUST: Packages must not own files or directories already owned by other
packages. OK
MUST: All filenames in rpm packages must be valid UTF-8. OK
SHOULD: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it. OK
SHOULD: The reviewer should test that the package builds in mock. OK
SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself. OK
Please fix the FIX items and consider fixing TODOs.
Resolution: NEEDSWORK.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=X7rFcbztgK&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
