Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891203
Miro Hrončok <mhron...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |
Flags| |fedora-review+
--- Comment #4 from Miro Hrončok <mhron...@redhat.com> ---
Description and Summary OK.
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces.
$ rpmlint ../SRPMS/nodejs-mime-1.2.7-2.fc18.src.rpm
../RPMS/noarch/nodejs-mime-1.2.7-2.fc18.noarch.rpm
nodejs-mime.src: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-mime.noarch: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-mime.noarch: W: only-non-binary-in-usr-lib
2 packages and 0 specfiles checked; 0 errors, 3 warnings.
All false positives. OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. OK
MUST: The package must meet the Packaging Guidelines. OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
Checked in LICENSE file, MIT. OK
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc. OK
MUST: The spec file must be written in American English. OK
MUST: The spec file for the package MUST be legible. OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL.
$ sha256sum ../SOURCES/mime-1.2.7.tgz
a80244918c9c75fa4d0b37f311920c7d5270aab9a05aca9a74783764ad152df6
../SOURCES/mime-1.2.7.tgz
$ spectool -g nodejs-mime.spec
Getting http://registry.npmjs.org/mime/-/mime-1.2.7.tgz to ./mime-1.2.7.tgz
$ sha256sum mime-1.2.7.tgz
a80244918c9c75fa4d0b37f311920c7d5270aab9a05aca9a74783764ad152df6
mime-1.2.7.tgz
OK
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. OK
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense. OK, build
in mock
MUST: Packages must NOT bundle copies of system libraries. OK
MUST: A package must own all directories that it creates. OK
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. OK
MUST: Permissions on files must be set properly.
$ rpm -q -lv -p ../RPMS/noarch/nodejs-mime-1.2.7-2.fc18.noarch.rpm
drwxr-xr-x 2 root root 0 led 13 22:02
/usr/lib/node_modules/mime
-rw-r--r-- 1 root root 2522 dub 29 2012
/usr/lib/node_modules/mime/mime.js
-rw-r--r-- 1 root root 567 čec 19 19:54
/usr/lib/node_modules/mime/package.json
drwxr-xr-x 2 root root 0 led 13 22:02
/usr/lib/node_modules/mime/types
-rw-r--r-- 1 root root 53011 kvě 7 2012
/usr/lib/node_modules/mime/types/mime.types
-rw-r--r-- 1 root root 1884 čec 19 19:52
/usr/lib/node_modules/mime/types/node.types
drwxr-xr-x 2 root root 0 led 13 22:02
/usr/share/doc/nodejs-mime-1.2.7
-rw-r--r-- 1 root root 1075 kvě 10 2011
/usr/share/doc/nodejs-mime-1.2.7/LICENSE
-rw-r--r-- 1 root root 2017 čec 19 19:49
/usr/share/doc/nodejs-mime-1.2.7/README.md
OK
MUST: Each package must consistently use macros. OK
MUST: The package must contain code, or permissable content. OK
MUST: If a package includes something as %doc, it must not affect the runtime
of the application. OK
MUST: Packages must not own files or directories already owned by other
packages. OK
MUST: All filenames in rpm packages must be valid UTF-8. OK
SHOULD: The reviewer should test that the package builds in mock. OK
SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself. OK
Package APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=8WOpnkV6Lv&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
