Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=891215
Miro Hrončok <mhron...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |
Flags| |fedora-review+
--- Comment #2 from Miro Hrončok <mhron...@redhat.com> ---
Description and Summary OK.
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
$ rpmlint ../SRPMS/nodejs-npm-registry-client-0.2.11-2.fc18.src.rpm
../RPMS/noarch/nodejs-npm-registry-client-0.2.11-2.fc18.noarch.rpm
nodejs-npm-registry-client.noarch: W: only-non-binary-in-usr-lib
nodejs-npm-registry-client.noarch: W: dangling-symlink
/usr/lib/node_modules/npm-registry-client/node_modules/retry
/usr/lib/node_modules/retry
nodejs-npm-registry-client.noarch: W: dangling-symlink
/usr/lib/node_modules/npm-registry-client/node_modules/semver
/usr/lib/node_modules/semver
nodejs-npm-registry-client.noarch: W: dangling-symlink
/usr/lib/node_modules/npm-registry-client/node_modules/rimraf
/usr/lib/node_modules/rimraf
nodejs-npm-registry-client.noarch: W: dangling-symlink
/usr/lib/node_modules/npm-registry-client/node_modules/mkdirp
/usr/lib/node_modules/mkdirp
nodejs-npm-registry-client.noarch: W: dangling-symlink
/usr/lib/node_modules/npm-registry-client/node_modules/chownr
/usr/lib/node_modules/chownr
nodejs-npm-registry-client.noarch: W: dangling-symlink
/usr/lib/node_modules/npm-registry-client/node_modules/request
/usr/lib/node_modules/request
nodejs-npm-registry-client.noarch: W: dangling-symlink
/usr/lib/node_modules/npm-registry-client/node_modules/slide
/usr/lib/node_modules/slide
nodejs-npm-registry-client.noarch: W: dangling-symlink
/usr/lib/node_modules/npm-registry-client/node_modules/graceful-fs
/usr/lib/node_modules/graceful-fs
nodejs-npm-registry-client.noarch: W: dangling-symlink
/usr/lib/node_modules/npm-registry-client/node_modules/couch-login
/usr/lib/node_modules/couch-login
2 packages and 0 specfiles checked; 0 errors, 10 warnings.
All are false positive.
Symlinks OK, package requires npm(chownr), npm(couch-login), npm(graceful-fs),
npm(mkdirp), npm(request), npm(retry), npm(rimraf), npm(semver) and npm(slide)
OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. OK
MUST: The package must meet the Packaging Guidelines. OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
Checked in LICENSE: BSD, OK.
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc. OK
MUST: The spec file must be written in American English. OK
MUST: The spec file for the package MUST be legible. OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL.
$ sha256sum ../SOURCES/npm-registry-client-0.2.11.tgz
4afff065051e1a30e806b47c531da4001b1ef35b01516f092aa51b41538e8e52
../SOURCES/npm-registry-client-0.2.11.tgz
$ spectool -g nodejs-npm-registry-client.spec
Getting
http://registry.npmjs.org/npm-registry-client/-/npm-registry-client-0.2.11.tgz
to ./npm-registry-client-0.2.11.tgz
$ sha256sum npm-registry-client-0.2.11.tgz
4afff065051e1a30e806b47c531da4001b1ef35b01516f092aa51b41538e8e52
npm-registry-client-0.2.11.tgz
OK
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. OK
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. OK, builds in mock
MUST: Packages must NOT bundle copies of system libraries. OK
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory. OK
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. OK
MUST: Permissions on files must be set properly.
$ rpm -q -lv -p
../RPMS/noarch/nodejs-npm-registry-client-0.2.11-2.fc18.noarch.rpm
drwxr-xr-x 2 root root 0 led 14 18:53
/usr/lib/node_modules/npm-registry-client
-rw-r--r-- 1 root root 2054 říj 4 00:08
/usr/lib/node_modules/npm-registry-client/index.js
drwxr-xr-x 2 root root 0 led 14 18:53
/usr/lib/node_modules/npm-registry-client/lib
-rw-r--r-- 1 root root 4533 srp 19 21:12
/usr/lib/node_modules/npm-registry-client/lib/adduser.js
-rw-r--r-- 1 root root 5508 říj 25 16:55
/usr/lib/node_modules/npm-registry-client/lib/get.js
-rw-r--r-- 1 root root 3739 srp 18 00:37
/usr/lib/node_modules/npm-registry-client/lib/publish.js
-rw-r--r-- 1 root root 9266 srp 27 20:54
/usr/lib/node_modules/npm-registry-client/lib/request.js
-rw-r--r-- 1 root root 798 srp 19 21:17
/usr/lib/node_modules/npm-registry-client/lib/star.js
-rw-r--r-- 1 root root 136 čen 7 2012
/usr/lib/node_modules/npm-registry-client/lib/tag.js
-rw-r--r-- 1 root root 2957 čen 7 2012
/usr/lib/node_modules/npm-registry-client/lib/unpublish.js
-rw-r--r-- 1 root root 586 čen 7 2012
/usr/lib/node_modules/npm-registry-client/lib/upload.js
drwxr-xr-x 2 root root 0 led 14 18:53
/usr/lib/node_modules/npm-registry-client/node_modules
lrwxrwxrwx 1 root root 28 led 14 18:53
/usr/lib/node_modules/npm-registry-client/node_modules/chownr ->
/usr/lib/node_modules/chownr
lrwxrwxrwx 1 root root 33 led 14 18:53
/usr/lib/node_modules/npm-registry-client/node_modules/couch-login ->
/usr/lib/node_modules/couch-login
lrwxrwxrwx 1 root root 33 led 14 18:53
/usr/lib/node_modules/npm-registry-client/node_modules/graceful-fs ->
/usr/lib/node_modules/graceful-fs
lrwxrwxrwx 1 root root 28 led 14 18:53
/usr/lib/node_modules/npm-registry-client/node_modules/mkdirp ->
/usr/lib/node_modules/mkdirp
lrwxrwxrwx 1 root root 29 led 14 18:53
/usr/lib/node_modules/npm-registry-client/node_modules/request ->
/usr/lib/node_modules/request
lrwxrwxrwx 1 root root 27 led 14 18:53
/usr/lib/node_modules/npm-registry-client/node_modules/retry ->
/usr/lib/node_modules/retry
lrwxrwxrwx 1 root root 28 led 14 18:53
/usr/lib/node_modules/npm-registry-client/node_modules/rimraf ->
/usr/lib/node_modules/rimraf
lrwxrwxrwx 1 root root 28 led 14 18:53
/usr/lib/node_modules/npm-registry-client/node_modules/semver ->
/usr/lib/node_modules/semver
lrwxrwxrwx 1 root root 27 led 14 18:53
/usr/lib/node_modules/npm-registry-client/node_modules/slide ->
/usr/lib/node_modules/slide
-rw-r--r-- 1 root root 772 led 14 18:53
/usr/lib/node_modules/npm-registry-client/package.json
drwxr-xr-x 2 root root 0 led 14 18:53
/usr/share/doc/nodejs-npm-registry-client-0.2.11
-rw-r--r-- 1 root root 1310 čec 24 03:28
/usr/share/doc/nodejs-npm-registry-client-0.2.11/LICENSE
-rw-r--r-- 1 root root 5192 srp 18 00:06
/usr/share/doc/nodejs-npm-registry-client-0.2.11/README.md
OK
MUST: Each package must consistently use macros. OK
MUST: The package must contain code, or permissable content. OK
MUST: If a package includes something as %doc, it must not affect the runtime
of the application. OK
MUST: Packages must not own files or directories already owned by other
packages. OK
MUST: All filenames in rpm packages must be valid UTF-8. OK
SHOULD: The reviewer should test that the package builds in mock. OK
SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself. OK
TODO: Run tests, when deps reach Fedora
Package APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=UeOMywQuPu&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
