Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=896101
--- Comment #6 from Michael Scherer <m...@zarb.org> --- A few comments : - ExclusiveOS: Linux is uneeded - there is no url for the code checkout nor where to download it - why are the debug package disabled when it shouldn't be needed ? - why does the s390 port have a specific variable in %post ? - .pyc should be packaged by the rpm to avoid doing that : if [ $1 = 0 ]; then rm -rf /usr/share/initial-setup/*.pyc rm -rf /usr/share/initial-setup/modules/*.pyc fi - %defattr(-,root,root,-) this should be uneeded - are you sure that systemd-sysv chkconfig are neeed in %post ? - you should use %_unitdir instead of hardcoding the path to systemd unit -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dAViFiM2dC&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
