Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=901387

--- Comment #2 from Mathieu Bridon <boche...@fedoraproject.org> ---
(In reply to comment #1)
> TODO: You can replace %{__perl} macro with plain perl command.

Fixed.

> TODO: Replace PERL_INSTALL_ROOT variable with DESTDIR in %install section.
> Current ExtUtils::MakeMaker understands DESTDIR.

Out of curiosity, do you know what is the minimal version of
ExtUtils::MakeMaker which started understanding DESTDIR? (to avoid closing the
door to EPEL builds, in this package or in my future submissions)

> TODO: Build-require `perl(Exporter)' (Affixes.pm:7).
> TODO: Build-require `perl(AutoLoader)' (Affixes.pm:8).

Fixed.

> TODO: Specify version constrain `>= 1.14' at perl(Test::Pod) (t/pod.t:4).
> TODO: Specify version constrain `>= 1.04' at perl(Test::Pod::Coverage)
> (t/pod-coverage.t:4).

Is that really necessary?

I mean, even EPEL 4 has recent enough versions...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=DYabZaM58W&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to