Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=884674
Rex Dieter <rdie...@math.unl.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |rdie...@math.unl.edu
Flags| |fedora-review?
--- Comment #10 from Rex Dieter <rdie...@math.unl.edu> ---
naming: ok
sources: NOT ok.
md5sum checksum in SRPM:
5c5167a012f43ccd0204fe600ef32095 kde-plasma-alsa-volume-0.41.2.tar.gz
md5sum of Source0 URL content:
146e0b1dae8ef5cfaa47b5fd75b93bdb kde-plasma-alsa-volume-0.41.2.tar.gz
1. srpm MUST contain verifiable sources
license: ok
2. MUST: add missing runtime dependency for plasma-scriptengine-python. i'd
suggest simply adding this to the top of your %build section:
if [ -x %{_bindir}/plasma-dataengine-depextractor ] ; then
plasma-dataengine-depextractor .
fi
then, it'll get added automatically for you. Doing this, you could probably
even drop the explicit,
Requires: PyKDE4
macros: ok
scriplets: n/a, ok
3. SHOULD simplify .spec and remove deprecated/used "Group:" tag
Otherwise, relatively small, simple package. Address at least MUST items 1,2
and i'll approve this.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=N84C1HzzND&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
