Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=896011

Ralf Corsepius <rc040...@freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040...@freenet.de

--- Comment #13 from Ralf Corsepius <rc040...@freenet.de> ---
(In reply to comment #12)
> (In reply to comment #11)
> > 2) Line 52; please avoid the %make_install macro.
> > 
> > https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/
> > Guidelines#Why_the_.25makeinstall_macro_should_not_be_used
> 
> Well, this is optional, is the %makeinstall macro which is forbidden. If you
> want to leave it as is, that's fine.
Not quite:

"Fedora's RPM includes a %makeinstall macro but it must NOT be used when make
install DESTDIR=%{buildroot} works."

"must NOT be used" => %make_install is only allowed as last resort, if a
package does not support "make DESTDIR=... install".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=SDJuyd1b9J&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to