Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=913481
--- Comment #2 from Petr Šabata <psab...@redhat.com> --- > 2 %global real_version 1.74_05 > 3 Version: 1.74.5 Upstream uses odd version numbers for previous even-numbered development releases so this is okay. However, I'd suggest using '1.74.05' to emphasize this is an unstable release, as done elsewhere. Missing BRs: * perl(Encode) from lib/Net/SFTP/Foreign.pm:17 * perl(Net::SFTP) from t/Net-SFTP-Foreign-Compat.t:5 * perl(POSIX) from lib/Net/SFTP/Foreign/Backend/Unix.pm:12 * perl(Tie::Handle) from lib/Net/SFTP/Foreign.pm:3049 You could also remove the Windows backend from the package completely as this won't ever be used in Fedora. Packaging debug.txt, TODO, rfc/ (even mentioned in %description), and samples/ (if you do, filter out their deps, e.g. with %perl_default_filter) in %doc would be nice. Also include LICENSE for sure. > 38 Requires: perl(lib) > 39 Requires: perl(Cwd) Those two are only used in tests, no reason to require them at runtime. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Vsl2NSZute&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
