Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=913004
Mathieu Bridon <boche...@fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |NEW
Flags| |fedora-cvs?
--- Comment #3 from Mathieu Bridon <boche...@fedoraproject.org> ---
(In reply to comment #2)
> Ok, no issues with your package.
Wait, I didn't forget any BuildRequires this time? \o/
> Perhaps doing plain "rm -r re2" in %prep would make the patch more readable.
> Just a personal opinion.
I thought about that, but I like the idea of just applying patches and nothing
else in the spec file, as much as possible.
Also, it feels weird to patch the MANIFEST so it doesn't include the re2 folder
anymore, while the folder itself is removed outside of the patch.
But yeah, it does make a world of difference concerning the readability of the
patch, which is very important for something like that (unbundling can be
tricky, I'd be happier if others can review the patch, so I should do what I
can to make that easier).
So I'll change that when importing the package.
> Approving.
Thanks Petr!
New Package SCM Request
=======================
Package Name: perl-re-engine-RE2
Short Description: RE2 regex engine
Owners: bochecha
Branches: devel
InitialCC: perl-sig
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=u0szC9ZQ6F&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
