Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=586433 Christoph Wickert <cwick...@fedoraproject.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cwick...@fedoraproject.org --- Comment #7 from Christoph Wickert <cwick...@fedoraproject.org> 2010-05-01 03:58:18 EDT --- In the %description, please insert line breaks at 80 characters, otherwise they wont fit on a terminal. Please don't start every sentence with Xnoise and please don't mention technical things like vala that are not important to the users. Suggestion: Xnoise is a media player written in GTK+ that can play every kind of audio/video data that gstreamer can handle. It uses a tracklist centric design and a hierarchical tree structure media browser along with plugin interface. Xnoise is always running in a single instance, this means that additional files will always be added to the tracklist instead of a new instance. Some more comments: You are using both %{buildroot} and ${RPM_BUILD_ROOT}. There is no benefit from one or the other, but please only use one macro style for consistency. The package doesn't own %{_datadir}/xnoise/ but only the files inside, thus an empty folder will remain after uninstall. The package contains libtool archives (*.la files) which is strictly forbidden in Fedora. You will have to remove them in %install with something like rm -f ${RPM_BUILD_ROOT}%{_libdir}/xnoise/*.la When you install icons to /usr/share/icons, you need to update the gtk icon-cache, see http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache /usr/share/locale/default/LC_MESSAGES/xnoise.mo seems bogus Please add a blank line between every changelog entry -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
