Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=915864

--- Comment #3 from Dan Radez <dra...@redhat.com> ---
Couple additions to my review:

%post should not mkdir
%install should and you should list the directories in your files


%post is not intended to completely configure the app so it can be started as
soon as the rpm install is completed. %post usually doesn't general feedback
either.

You should provide a config script for the user to execute after installation
to do most of the configuration that is currently in %post

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=Ybe4ASFR6o&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to