Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=911673

Kalev Lember <kalevlem...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|nob...@fedoraproject.org    |kalevlem...@gmail.com
              Flags|                            |fedora-review+

--- Comment #6 from Kalev Lember <kalevlem...@gmail.com> ---
I'm approving this based on Jeremy's review (thanks Jeremy!). I've done some
additional checks to make sure it builds in koji and that the upgrade path
looks sane, and it all looks good.

I've got two really minor nitpicks:
 a) might be nice to sort the BRs and the %files list, and
 b) the --all-name option to the %find_lang macro is unnecessary here; all the
docs / translations are installed under the 'swell-food' name.

Feel free to change these before importing, if you think it makes sense.

Looks good. APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=zqqwpL7GB8&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to