Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=918532
--- Comment #4 from Kalev Lember <kalevlem...@gmail.com> ---
Fedora review four-in-a-row-3.7.92-1.fc20.src.rpm 2013-03-23
+ OK
! needs attention
rpmlint output:
$ rpmlint four-in-a-row \
four-in-a-row-debuginfo-3.7.92-1.fc19.x86_64.rpm \
four-in-a-row-3.7.92-1.fc19.src.rpm
four-in-a-row.x86_64: W: name-repeated-in-summary C Four-in-a-row
four-in-a-row.x86_64: W: obsolete-not-provided gnome-games-gnect
four-in-a-row.x86_64: E: incorrect-fsf-address
/usr/share/doc/four-in-a-row-3.7.92/COPYING
four-in-a-row-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/four-in-a-row-3.7.92/src/main.c
four-in-a-row-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/four-in-a-row-3.7.92/src/games-stock.h
four-in-a-row-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/four-in-a-row-3.7.92/src/games-stock.c
four-in-a-row-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/four-in-a-row-3.7.92/src/gfx.c
four-in-a-row-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/four-in-a-row-3.7.92/src/games-fullscreen-action.c
four-in-a-row-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/four-in-a-row-3.7.92/src/games-fullscreen-action.h
four-in-a-row-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/four-in-a-row-3.7.92/src/prefs.c
four-in-a-row-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/four-in-a-row-3.7.92/src/theme.c
four-in-a-row.src: W: name-repeated-in-summary C Four-in-a-row
3 packages and 0 specfiles checked; 9 errors, 3 warnings.
+ Rpmlint warnings / errors are harmless and can be ignored
+ The package is named according to Fedora packaging guidelines
+ The spec file name matches the base package name.
+ The package meets the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The package contains the license file (COPYING)
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match sources in the srpm. md5sum:
7b744b8abf9a8f0a824302a79f3c8b1f four-in-a-row-3.7.92.tar.xz
7b744b8abf9a8f0a824302a79f3c8b1f Download/four-in-a-row-3.7.92.tar.xz
+ The package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
+ The spec file handles locales properly
n/a ldconfig in %post and %postun
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
+ Package owns all the directories it creates
+ No duplicate files in %files
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
n/a Static libraries should be in -static
n/a Library files that end in .so must go in a -devel package
n/a -devel must require the fully versioned base
+ Packages should not contain libtool .la files
+ Proper .desktop file handling
+ Doesn't own files or directories already owned by other packages
+ Filenames are valid UTF-8
Issues
------
> # Contacted the translator. Should be fixed upstream at some point
> Patch1: ug-po.patch
Please submit it to bugzilla.gnome.org as well.
Also, two really minor nitpicks; feel free to change these before importing, if
you think it makes sense:
a) might be nice to sort the BRs and the %files list, and
b) the --all-name option to the %find_lang macro is unnecessary here; all the
docs / translations are installed under the 'four-in-a-row' name.
APPROVED
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=5c5QRlaTQS&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
