Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927310
Michael Schwendt <mschwe...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mschwe...@gmail.com
--- Comment #1 from Michael Schwendt <mschwe...@gmail.com> ---
It's surprising how you've mispackaged this library. :-(
> License: GPL2 with linking exemption.
As a valid tag, at most there is "License: GPLv2 with exceptions" in the Fedora
Licensing guidelines: https://fedoraproject.org/wiki/Licensing:Main
> pure C implementation
If it's written in C, a working -debuginfo package ought to be built.
> # Cleanup
> rm -rf %{buildroot}/usr/lib/debug %{buildroot}/usr/src/debug
https://fedoraproject.org/wiki/Packaging:Guidelines#Debuginfo_packages
> Requires: %{name} = %{version}-%{release}
https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package
> %package devel
> Summary: The Git linkable library
This is half-hearted summary for the -devel package. That package does not
contain the library, but just the files needed for building software that uses
libgit2.
> %description devel
> libgit2 is a portable, pure C implementation of the
> Git core methods provided as a re-entrant linkable
> library with a solid API, allowing you to write native
> speed custom Git applications in any language with bindings.
Same here. Just copying the %description of the base package is misleading.
> /usr/lib/%{name}*
And what about target platforms where %{_libdir} is /usr/lib64?
> %files devel
> /usr/include/git2*
> /usr/lib/pkgconfig
Same here. And since the package cannot be built yet, I assume one of the
library files is misplaced, too:
https://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages
A simple test-build for Fedora 18 fails very early, unfortunately.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=2O6KdWkkCd&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
