Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=902017
--- Comment #15 from Gerard Ryan <ger...@ryan.lt> ---
(In reply to comment #14)
> Package Review
> ==============
>
> Key:
> [x] = Pass
> [!] = Fail
> [-] = Not applicable
> [?] = Not evaluated
> [ ] = Manual review needed
>
>
> Issues:
> =======
>
> [!]: Changelog in prescribed format.
> >>>> There must either be a space on both sides of the delimiting dash, or
> >>>> no delimiting dash at all. I. e.
> >>>> ...t.org> - 2.0.3-2
> >>>> or
> >>>> ...t.org> 2.0.3-2
Fixed.
> [!]: Package complies to the Packaging Guidelines
> [!]: If (and only if) the source package includes the text of the license(s)
> in its own file, then that file, containing the text of the license(s)
> for the package is included in %doc.
> >>>> you should include
> >>>> %doc license epl-v10.html
> >>>> in %files and %files javadoc
Oops. I don't know how that got removed, thanks for pointing it out. Fixed.
> Notes:
> ======
>
> [!]: Requires correct, justified where necessary.
> >>>> You don't need to specify Requires when building with %mvn_build
Fixed. I've left in Requires on jsch since it doesn't have a maven POM.
DIFF of specfile since previous uploaded version
===========================================================
@@ -4,7 +4,7 @@
Name: openshift-java-client
Version: 2.0.3
-Release: 2.%{checkout}%{?dist}
+Release: 3.%{checkout}%{?dist}
Summary: OpenShift Java Client
Group: Development/Libraries
@@ -13,7 +13,6 @@ URL: http://openshift.redhat.com
Source0:
https://github.com/openshift/%{name}/archive/%{commit}/%{name}-%{version}-%{shortcommit}.tar.gz
BuildArch: noarch
-BuildRequires: java-devel
BuildRequires: maven-local
BuildRequires: jsch
BuildRequires: mvn(org.easytesting:fest-assert)
@@ -25,11 +24,6 @@ BuildRequires: mvn(log4j:log4j)
BuildRequires: mvn(org.codehaus.mojo:properties-maven-plugin)
BuildRequires: mvn(commons-io:commons-io)
Requires: jsch
-Requires: mvn(org.jboss:jboss-dmr)
-Requires: mvn(org.slf4j:slf4j-log4j12)
-Requires: mvn(commons-io:commons-io)
-Requires: mvn(org.codehaus.mojo:properties-maven-plugin)
-Requires: java
%description
This is a client for OpenShift written in java. It pretty much offers all
@@ -57,13 +51,20 @@ API documentation for %{name}.
%files -f .mfiles
%dir %{_javadir}/%{name}
+%doc license epl-v10.html
%files javadoc -f .mfiles-javadoc
+%doc license epl-v10.html
%changelog
-* Wed Mar 20 2013 Gerard Ryan <gali...@fedoraproject.org> -2.0.3-2
+* Fri Mar 29 2013 Gerard Ryan <gali...@fedoraproject.org> - 2.0.3-3
+- Fix changelog.
+- Remove unneeded Requires.
+- Added epl-v10.html as a doc to main and javadoc packages.
+
+* Wed Mar 20 2013 Gerard Ryan <gali...@fedoraproject.org> - 2.0.3-2
- Update to fix licensing and new Base64Coder implementation.
- Use new maven macros.
-* Sun Jan 20 2013 Gerard Ryan <gali...@fedoraproject.org> -2.0.3-1
+* Sun Jan 20 2013 Gerard Ryan <gali...@fedoraproject.org> - 2.0.3-1
- Initial package.
=========================================================================
Spec URL:
http://galileo.fedorapeople.org/openshift-java-client/2.0.3-3/openshift-java-client.spec
SRPM URL:
http://galileo.fedorapeople.org/openshift-java-client/2.0.3-3/openshift-java-client-2.0.3-3.20130320git7073708.fc18.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=FVqKaTXzF0&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
