Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=588654 Andrew Overholt <overh...@redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |overh...@redhat.com AssignedTo|nob...@fedoraproject.org |overh...@redhat.com Flag| |fedora-review? --- Comment #1 from Andrew Overholt <overh...@redhat.com> 2010-05-04 14:38:06 EDT --- Thanks for the submission. My review is below. * = okay, X = work to be done * naming fine X release incorrect. see: http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Package_Release X drop the explicit Epoch (it's unnecessary) X license tag incorrect (it should be ASL 2.0): see http://fedoraproject.org/wiki/Licensing#SoftwareLicenses X source appears to have been generated from a different tag. The difference is inconsequential but I'd prefer if it was re-generated. See the diff here: http://overholt.fedorapeople.org/plexus-component-api-1.0-alpha-15.diff X Requires need to be fixed: add Requires(post) and Requires(postun) on jpackage-utils * macros okay (but why mix %{__rm} and plain rm?) X should there be an un-versioned copy of the JAR? * rpmlint warnings are okay (license covered above and others are ignorable) $ rpmlint ../SRPMS/plexus-component-api-1.0-alpha15.1.src.rpm plexus-component-api.src: W: invalid-license Apache Software License 2.0 plexus-component-api.src: W: invalid-url Source0: plexus-component-api-1.0-alpha-15.tar.gz 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpmlint ../RPMS/noarch/plexus-component-api-1.0-alpha15.1.fc12.noarch.rpm plexus-component-api.noarch: W: invalid-license Apache Software License 2.0 plexus-component-api.noarch: W: no-documentation plexus-component-api.noarch: W: non-conffile-in-etc /etc/maven/fragments/plexus-component-api 1 packages and 0 specfiles checked; 0 errors, 3 warnings. $ rpmlint ../RPMS/noarch/plexus-component-api-javadoc-1.0-alpha15.1.fc12.noarch.rpm plexus-component-api-javadoc.noarch: W: invalid-license Apache Software License 2.0 1 packages and 0 specfiles checked; 0 errors, 1 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
