Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927269

--- Comment #5 from Michal Schmidt <mschm...@redhat.com> ---
Thanks for adding make-git-snapshot.sh and the comment in the spec on how to
use it. That's helpful.

Regarding the Release tag: A leading zero usually indicates a pre-release
snapshot (see the NamingGuidelines) of the stated Version. However, your
snapshot is newer than version 0.5.0, so the release should not start with a
zero.

You forgot to add a %changelog entry.

Most importantly, the package does not build in mock:

...
checking for EGL... no
...
Processing files: xorg-x11-glamor-0.5.0-0.20130401git81aadb8.fc20.x86_64
error: File not found:
/builddir/build/BUILDROOT/xorg-x11-glamor-0.5.0-0.20130401git81aadb8.fc20.x86_64/usr/lib64/xorg/modules/libglamoregl.so
    File not found:
/builddir/build/BUILDROOT/xorg-x11-glamor-0.5.0-0.20130401git81aadb8.fc20.x86_64/usr/lib64/xorg/modules/libglamoregl.so
RPM build errors:
Child return code was: 1

My guess is you're missing some BuildRequires.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=TEnsgKcVGu&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to