Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=948345
Kalev Lember <kalevlem...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |kalevlem...@gmail.com
Assignee|nob...@fedoraproject.org |kalevlem...@gmail.com
--- Comment #1 from Kalev Lember <kalevlem...@gmail.com> ---
The header files all have the execute bit set, is it something we should try to
fix up in the downstream spec file?
> Source0: http://ftp.mozilla.org/pub/mozilla.org/js/mozjs17.0.0.tar.gz
Should use the %{version} macro to make future updates easier.
> %package devel
> ...
> Requires: pkgconfig
rpmbuild generates the pkgconfig dep automatically for packages that have .pc
files, no need for the manual requires line.
> %package devel
> ...
> Requires: ncurses-devel readline-devel
Does it really need ncurses/readline headers? I couldn't find any
ncurses/readline includes in the js header files, at least.
> %prep
> ...
> (cd js/src && autoconf-2.13)
Not sure the autoconf is necessary, might be cleaner to just remove it.
> %clean
> rm -rf %{buildroot}
The clean section is no longer needed with recent rpmbuild.
> %files
> %defattr(-,root,root,-)
> ...
> %files devel
> %defattr(-,root,root,-)
rpmbuild sets a sane defattr itself nowadays, no need to specify it here.
> %doc js/src/README.html
Not sure the README.html is very interesting, just contains a link. Maybe add
README instead? One file that's definitely needs adding is the LICENSE file.
> %{_bindir}/js17-config
This should be in -devel I guess, not in the main library package.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=erwZNiVBVZ&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
