Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=946856
--- Comment #6 from Lokesh Mandvekar <l...@buffalo.edu> --- Spot, Following should hopefully address most of your comments: Spec URL: https://github.com/lsm5/rpmbuild/blob/master/SPECS/spectrwm.spec SRPM URL: https://github.com/lsm5/rpmbuild/blob/master/SRPMS/spectrwm-2.2.0-2.fc20.src.rpm koji build: https://github.com/lsm5/rpmbuild/blob/master/SRPMS/spectrwm-2.2.0-2.fc20.src.rpm $ rpmlint SRPMS/spectrwm-2.2.0-2.fc20.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint SPECS/spectrwm.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint RPMS/x86_64/spectrwm-2.2.0-2.fc20.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint RPMS/x86_64/spectrwm-devel-2.2.0-2.fc20.x86_64.rpm spectrwm-devel.x86_64: E: invalid-soname /usr/lib64/libswmhack.so.0.0 swm_hack.so spectrwm-devel.x86_64: W: no-documentation 1 packages and 0 specfiles checked; 1 errors, 1 warnings. Could you please take a look at the patch for -Wl,-soname and let me know if I'm doing it right? https://github.com/lsm5/rpmbuild/blob/master/SOURCES/spectrwm-2.2.0-versioned-shared-lib.patch Also, I'm not sure what to include in spectrwm-devel documentation. Is it ok to leave it blank? spectrwm includes man pages in documentation. Finally, I'm guessing when I say 'yum install spectrwm', I would want libswmhack.so.0.0 and symlinks (in spectrwm-devel) installed as well. But since my spec file says spectrwm-devel requires spectrwm, would I have to say 'yum install spectrwm-devel' in order to get the complete installation? Or should I be changing the subpackage name suitably (libspectrwm perhaps)? Or have I gotten it wrong totally? Thanks, -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wo0KSaBp48&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
