Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=854256
Lokesh Mandvekar <l...@buffalo.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |l...@buffalo.edu
--- Comment #4 from Lokesh Mandvekar <l...@buffalo.edu> ---
Hi Erik,
Well, first off thanks for helping me use TIPC 2.0 with UDP bearers sometime
back.
Are you still interested in proceeding with this review request?
If you are (and I'm hoping you would be), I'd like to help with the package
review, coz this program is useful to me too. I'm not a sponsor and I'm in
process of getting my first package reviewed.
* The Release number needs to be incremented everytime you make a change to the
spec file, along with a Changelog entry for it.
* Fedora requires that files not be directly installed to /sbin. /usr/sbin is
preferable in this case. Check this out:
https://fedoraproject.org/wiki/Packaging:Guidelines#Filesystem_Layout
* In the %files section, use macros for directory names (for eg. %{_bindir}
instead of /usr/bin)
* Run rpmlint on the spec, srpm and binary rpm files and post their outputs.
* Run the srpm file through koji and provide a link to the build here. Koji
HOWTOs:
https://fedoraproject.org/wiki/Using_the_Koji_build_system?rd=Koji/UsingKoji
* The Source URL isn't accessible anymore. Could you please check that out?
There might be other issues (but I'm sorta new to reviewing myself, and will
revisit this as and when I learn new stuff).
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=TVtQ0CpNJr&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
