Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=927611
John Morris <j...@zultron.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org |j...@zultron.com
--- Comment #4 from John Morris <j...@zultron.com> ---
Created attachment 735771
--> https://bugzilla.redhat.com/attachment.cgi?id=735771&action=edit
fedora-review results with reviewer notes
Here's the review. These comments may also be found at the bottom of the
attached file.
Reviewer notes
----------------------------------------
[!]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
Rpmlint: pyode.x86_64: W: no-documentation
- No documentation
%doc should include AUTHORS ChangeLog LICENSE LICENSE-BSD README examples
----------
[!]: Requires correct, justified where necessary.
- Need Requires: ode and Pyrex
----------
[!]: Package meets the Packaging Guidelines::Python
- Python3 support: Infra is in specfile; does it work, and if so,
should it be turned on?
----------
[!]: %check is present and all tests pass.
- Has this package been tested? This %check script fails with a
segfault, as does running the tests after install:
%check
export PYTHONPATH=build/lib.linux-%{_target_cpu}-%{python_version}
%{__python} tests/test_xode.py
----------
Rpmlint: pyode.x86_64: W: non-standard-group Unspecified
- Main package missing Group: tag (though python3 package includes
it). I want this to be included in EPEL, where Group: is not
optional.
http://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=XEDf4fSGy3&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
