Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=588474 Matthew Kent <mk...@magoazul.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mk...@magoazul.com --- Comment #4 from Matthew Kent <mk...@magoazul.com> 2010-05-06 04:09:16 EDT --- Wow, lots of rubygem submissions. This applies to all of yours: This isn't a full review but have you read https://fedoraproject.org/wiki/Packaging/Ruby you'll need at least the rubyabi added, see http://magoazul.com/wip/SPECS/rubygem-amqp.spec for a reference (accepted yesterday). Also give http://fedoraproject.org/wiki/PackagingGuidelines#.25global_preferred_over_.25define a look. The ruby_sitelib macro is unnecessary for anything without a compiled extension. Finally have you verified the License for each? Bug #588473 for example is MIT licensed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
