Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=951496
Antonio Trande <anto.tra...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |anto.tra...@gmail.com
--- Comment #2 from Antonio Trande <anto.tra...@gmail.com> ---
Hi Graham.
Just some comments.
- "Compilers used to build packages must honor the applicable compiler flags
set in the system rpm configuration. For C, C++, and Fortran code, the
%{optflags} macro contains these flags."
http://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags
See that Makefile uses right flags.
- Source archive contains files released with GPLv3+ (see src/gimplensfun.c,
src/LUT.h files). I think License tag must be GPLv3+.
http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Mixed_Source_Licensing_Scenario
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=UrDGXILvYd&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
