Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=946856
Tom "spot" Callaway <tcall...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|177841 (FE-NEEDSPONSOR) |
Flags| |fedora-review+
--- Comment #27 from Tom "spot" Callaway <tcall...@redhat.com> ---
== Review ==
Good:
- rpmlint checks return:
spectrwm-devel.x86_64: W: no-documentation
- package meets naming guidelines
- package meets packaging guidelines
- license (ISC) OK, matches source
- spec file legible, in am. english
- source matches upstream
(9fc4100530005b6d97c1b2fe81e78d0bf10425ecd57f2c523db6b36e83dab103)
- package compiles on f18 (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- no need for .desktop file
- devel package ok
- no .la files
- post/postun ldconfig ok
- devel requires base package n-v-r
APPROVED.
I'm going to sponsor you right now. You'll be at this step:
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Get_Sponsored
Let me know if you have any questions about how to move forward.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=d8U8jDra7q&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
