Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=589471

Marcela Mašláňová <mmasl...@redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nob...@fedoraproject.org    |mmasl...@redhat.com
               Flag|                            |fedora-review+

--- Comment #1 from Marcela Mašláňová <mmasl...@redhat.com> 2010-05-07 03:45:40 
EDT ---
Almost good ;-)

Only few comments:
Remove this, MODULE_COMPAT it's enough -> BuildRequires:  perl >= 1:5.6.0
Also do you need all requires? Don't they needed only as BuildRequires?
Change PERL_INSTALL_ROOT to DESTDIR, because this bug wasn't still removed from
cpanspec ;-)

None of these are blockers. Please fix it before upload.

ACCEPTED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to