Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=957238
Michael Scherer <m...@zarb.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m...@zarb.org
Assignee|nob...@fedoraproject.org |m...@zarb.org
Flags| |fedora-review+
--- Comment #1 from Michael Scherer <m...@zarb.org> ---
- There is a gplv2+ note in acoustic_model, but there is another note saying
gplv3+ at the top level. While gpl v3+ is correct from a legal point of view,
isn't it more precise to say this is gplv2+ ?
Anyway, that's not blocking for the review ( since both are free and compatible
and permitted to be distributed as gpl v3 ), and the package is approved ( as
julius is update-testing )
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 4 files have unknown license. Detailed output of
licensecheck in /home/misc/checkout/git/FedoraReview/957238-julius-
voxforge/licensecheck.txt
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 20480 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[!]: Rpmlint is run on all installed packages.
Note: Mock build failed
[x]: Large data in /usr/share should live in a noarch subpackage if package is
arched.
[x]: Spec file according to URL is the same as in SRPM.
Installation errors
-------------------
INFO: mock.py version 1.1.32 starting...
Start: init plugins
INFO: selinux enabled
Finish: init plugins
Start: run
Mock Version: 1.1.32
INFO: Mock Version: 1.1.32
Start: lock buildroot
INFO: installing package(s):
/home/misc/checkout/git/FedoraReview/957238-julius-voxforge/results/julius-voxforge-2013.03.01-1.fc19.noarch.rpm
ERROR: Command failed:
# ['/usr/bin/yum', '--installroot', '/var/lib/mock/fedora-19-x86_64/root/',
'install',
'/home/misc/checkout/git/FedoraReview/957238-julius-voxforge/results/julius-voxforge-2013.03.01-1.fc19.noarch.rpm',
'--setopt=tsflags=nocontexts']
Erreur : Paquet : julius-voxforge-2013.03.01-1.fc19.noarch
(/julius-voxforge-2013.03.01-1.fc19.noarch)
Requiert : julius
Vous pouvez essayer d'utiliser --skip-broken pour contourner le problème
Vous pouvez essayer d'exécuter : rpm -Va --nofiles --nodigest
Rpmlint
-------
Checking: julius-voxforge-2013.03.01-1.fc19.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Requires
--------
julius-voxforge (rpmlib, GLIBC filtered):
julius
Provides
--------
julius-voxforge:
julius-voxforge
Source checksums
----------------
http://www.repository.voxforge1.org/downloads/Nightly_Builds/current/Julius-4.2-Quickstart-Linux_AcousticModel-2013-03-01.tgz
:
CHECKSUM(SHA256) this package :
143d1e1290d9c6016a8a12151d4ffdd4b96e4c13ea73c153814b5b094d4db0d0
CHECKSUM(SHA256) upstream package :
143d1e1290d9c6016a8a12151d4ffdd4b96e4c13ea73c153814b5b094d4db0d0
Generated by fedora-review 0.4.0 (cf29f98) last change: 2013-02-08
Buildroot used: fedora-19-x86_64
Command line :./try-fedora-review -b 957238
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=icwERZ0lwv&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
