Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=928226
--- Comment #5 from David Tardon <dtar...@redhat.com> --- Spec URL: http://dtardon.fedorapeople.org/rpm/libmwaw.spec SRPM URL: http://dtardon.fedorapeople.org/rpm/libmwaw-0.1.7-1.fc18.src.rpm (In reply to comment #3) > Full review below. TODO items: > > - MUST: The package must contain a comment explaining the multiple licensing > breakdown [2] Fair enough, added. > > - SHOULD: Comments on status of patches (upstreamable, upstreamed?) I would probably make a note if there were a Fedora-specific patch. > > - OTHER: Upstream should be notified about incorrect FSF address of > libmwaw-0.1.7/src/tools/zip/zip.cpp Yes, I know. I have not been in a hurry about this one because the file is not built in the package. > > - OTHER: install docs in %{_docdir}/%{name} or as %doc? If in > %{_docdir}/%{name}, why not just use > %{_docdir}/%{name}/ > instead of > %dir %{_docdir}/%{name} > %{_docdir}/%{name}/html > ? I guess I am just accustomed to this. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9l5lIlx1lw&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
