Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=954182
--- Comment #4 from Micah Roth <micah.r...@ucla.edu> --- > Just remove the whole if clause, everything is working fine without it. Fixed. > Don't ship the static library (.a). Either delete it or don't build it in > the first place. Fixed. With cmake, how can I avoid building it in the first place? Is there something like --disable-static for cmake? A quick google didn't show anything promising... > # skipped RPATH due to build errors, also following upstream's spec example > -- That comment is misleading. It's part of our guidelines not to allow > rpaths, refer to > http://fedoraproject.org/wiki/Packaging:Guidelines#Beware_of_Rpath. Just > drop it. Fixed. > Please be more specific about the manfiles, the headers and also the name of > the library. Doing that, you'll notice, the manpages are installed in the > wrong place: /usr/share/man/man/man1/ctpp2-config.1.gz should be > /usr/share/man/man1/ctpp2-config.1.gz. Fixed, so long as I am now being specific enough in the %%files sections. > Don't ship INSTALL. Fixed. I will avoid that in the future. Sorry. > I'd suggest to not use the version macro in Patch0. You'd have to rename a > fitting patch on every update. Fixed. New URLs: Spec URL: http://multiseatlibrary.distract.org/files/ctpp2.spec SRPM URL: http://multiseatlibrary.distract.org/files/ctpp2-2.7.1-3.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8opOD08A44&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
