Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=952354
--- Comment #4 from Vasant Hegde <hegdevas...@in.ibm.com> ---
Few more comments:
- License statement is not required in spec file.
- 'package_version' and 'package_name' are not really needed. They only
duplicate %{name} and {version}.
- BuildRoot is obselete
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
- The timestamps are not preserved in the %install section.
- 'rm -rf "%{buildroot}' is not required.
- %changelog : requires description of changes
The package is named 'ovirt-log-collector', the binary 'engine-log-collector',
the manpage 'engine-log-collector.8.gz', and the configuration file
'logcollector.conf'. IMO consistent naming schema helps ot identify compoenents
which belong together.
-Vasant
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=dqXNlAK3z2&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
