Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=957568

Mario Blättermann <mario.blaetterm...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|nob...@fedoraproject.org    |mario.blaetterm...@gmail.co
                   |                            |m
              Flags|                            |fedora-review?

--- Comment #8 from Mario Blättermann <mario.blaetterm...@gmail.com> ---
Some more issues:

cp pycard.conf.sample %{buildroot}%{_sysconfdir}/pycard.conf.sample

Either mark it as a config file by prepending %config(noreplace), or place it
in %doc. Normally, users will create their own config files, that's why it
would be sufficient to have it in %doc. I'm in doubt if it would work
out-of-the-box as a config file due to the *.sample file extension.

"Source:" should be "Source0:" independent from the actual count of source
files.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=PIuHXjVWX6&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to