Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=896310
--- Comment #7 from Rich Mattes <richmat...@gmail.com> ---
I think it's ok to have the -doc package require the -devel subpackage, in
spite of the rpmlint error (rpmlint is not authoratative, the packaging
guidelines are.) From reading the packaging guidelines section on
documentation, they suggest that development documentation be included with the
-devel package. They also say that large documentation should be split off
into a -doc subpackage, but nowhere does it say anything about not being able
to split out development documentation into a separate package.
I think this is also a special case. There is no base package, and the
documentation pertains to the -devel subpackage.
Finally, the way the spec is currently written, it is impossible to install the
-doc subpackage. It depends on odeint-2.2-2, which doesn't exist:
$ sudo yum -C localinstall ../RPMS/noarch/odeint-d*
Loaded plugins: auto-update-debuginfo, fastestmirror, langpacks, presto
Examining ../RPMS/noarch/odeint-devel-2.2-2.fc18.noarch.rpm:
odeint-devel-2.2-2.fc18.noarch
Marking ../RPMS/noarch/odeint-devel-2.2-2.fc18.noarch.rpm to be installed
Examining ../RPMS/noarch/odeint-doc-2.2-2.fc18.noarch.rpm:
odeint-doc-2.2-2.fc18.noarch
Marking ../RPMS/noarch/odeint-doc-2.2-2.fc18.noarch.rpm to be installed
Resolving Dependencies
--> Running transaction check
---> Package odeint-devel.noarch 0:2.2-2.fc18 will be installed
---> Package odeint-doc.noarch 0:2.2-2.fc18 will be installed
--> Processing Dependency: odeint = 2.2-2.fc18 for package:
odeint-doc-2.2-2.fc18.noarch
--> Finished Dependency Resolution
Error: Package: odeint-doc-2.2-2.fc18.noarch (/odeint-doc-2.2-2.fc18.noarch)
Requires: odeint = 2.2-2.fc18
You could try using --skip-broken to work around the problem
You could try running: rpm -Va --nofiles --nodigest
So go ahead and add Requires: %{name}-devel = %{version}-%{release} to the -doc
subpackage
Also, the github upstream URL is broken. For starters, it looks like the
commit listed in the specfile doesn't exist in the odeint repository. The
commit for the v2.2 tag, according to
https://github.com/headmyshoulder/odeint-v2/tags, is
421f879c6478ec23ea4e398fb47f8a621ff784e6.
So as per http://fedoraproject.org/wiki/Packaging:SourceURL#Github, the Source0
should read
https://github.com/headmyshoulder/odeint-v2/archive/%{commit}/%{name}-%{version}-%{shortcommit}.tar.gz
and %prep should have:
%setup -qn %{name}-v2-%{commit}
That will fix the invalid Source0 messages (I tried it locally and it looks
like everything worked fine.)
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=2bs0JOEF4O&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
