Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960839
--- Comment #2 from Parag AN(पराग) <panem...@gmail.com> --- + koji scratch build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=5346037 + rpmlint on rpms gave lang-table-python.noarch: W: no-documentation lang-table-data.noarch: W: summary-not-capitalized C data files for lang-table lang-table-data.noarch: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 3 warnings. ==> Fix summary for lang-table-data Issues: ======= 1) Package contains BR: python2-devel or python3-devel See: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires 2) No Requires: %{name}%{?_isa} = %{version}-%{release} in lang-table-python , lang-table-data 3) No need to write for python packages now following in spec for only Fedora specific packages %{!?python_sitelib: %define python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")} 4) One more suggestion for upstream, I am confused actually with the usage of lang-table and langtable words. Can upstream use any single word everywhere? like package name is lang-table but python source file is langtable.py Shouldn't then your package name be python-langtable for your python subpackage. See http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28python_modules.29 5) I am a bit confused about licensing here. all *.py files have header for LGPLv3+ whereas setup.py says that module is in GPLv3+ Also, you need to specify "and MIT" in license tag and add comment about which code is in which license. I see unicode-license,txt refers to "Modern Style without sublicense (Unicode)" license whose short form is MIT -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=J4aghVSSRJ&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
