Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=916797
Erik van Pienbroek <erik-fed...@vanpienbroek.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |erik-fed...@vanpienbroek.nl
Flags| |fedora-review?
--- Comment #2 from Erik van Pienbroek <erik-fed...@vanpienbroek.nl> ---
Taking for review
- The '%global mingw_build_win32/64' isn't needed any more and can be removed
- The pkgname variable also isn't needed any more (although you can leave it
'as is' if you like it better this way)
- The 'BuildRequires: mingw32-filesystem' is unversioned while it should be '>=
95'
- In various places you've used the terms 'dynamic' and 'static'. I think it
would be more clear to other users if you use 'shared' and 'static' as these
terms are more common
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=23mGYn9MEw&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
