Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=963693
Mikolaj Izdebski <mizde...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |needinfo?(m...@redhat.com)
--- Comment #1 from Mikolaj Izdebski <mizde...@redhat.com> ---
1. Please create a separate script (generate-sources.sh) to generate clean
tarball. It will make it easier for me to verify sources and should improve
maintaiability in future.
2. Please describe the patch. Why is it needed? Is it upstreamable? Was it
submited upstream?
3. According %pom_add_dep "commons-lang:commons-lang"
Is this a bug (missing dependency)? Is upstream aware of it? Please clarify.
4. Readme files should not be installed with javadoc package.
5. Since you generated the tarball yourself it would make sense to name it
better. Current name is 1.1-jenkins-20120928-clean.tar.gz, something standard
like jenkins-commons-jelly-1.1.20120928-clean.tar.gz would probably be better.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=8tXJcqCjIF&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
