Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=962470
Tom "spot" Callaway <tcall...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |tcall...@redhat.com
Assignee|nob...@fedoraproject.org |tcall...@redhat.com
Flags| |fedora-review+
--- Comment #2 from Tom "spot" Callaway <tcall...@redhat.com> ---
Review was done on the cdi-api11 package.
= Review =
Good:
- rpmlint checks return nothing
- package meets naming guidelines
- package meets packaging guidelines
- license (ASL 2.0) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
(487632079089c4f48ef20578a15f1cd24b396c06e5f9f925e636a5b953585e21)
- package compiles on f19 (noarch)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- -javadocs ok
- nothing in %doc affects runtime
- no need for .desktop file
APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=z4mfgKa7q1&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
