Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=962452
Tom "spot" Callaway <tcall...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |tcall...@redhat.com
Assignee|nob...@fedoraproject.org |tcall...@redhat.com
Flags| |fedora-review+
--- Comment #2 from Tom "spot" Callaway <tcall...@redhat.com> ---
= Review =
Good:
- rpmlint checks return:
jaxb2-maven-plugin.noarch: W: spelling-error %description -l en_US Mojo's ->
Moho's, Moo's, Mono's
jaxb2-maven-plugin.src: W: spelling-error %description -l en_US Mojo's ->
Moho's, Moo's, Mono's
jaxb2-maven-plugin.src: W: invalid-url Source0:
jaxb2-maven-plugin-1.5-src-svn.tar.gz
All safe to ignore.
- package meets naming guidelines
- package meets packaging guidelines
- license (ASL 2.0) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream (manual diff due to SVN source)
- package compiles on f19 (noarch)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- -javadocs ok
- nothing in %doc affects runtime
- no need for .desktop file
APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=9BvosDOyjA&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
