Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=963074
Parag AN(पराग) <panem...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |
Flags| |fedora-review+
--- Comment #4 from Parag AN(पराग) <panem...@gmail.com> ---
Suggestions:
1) #Requires: line should be removed as its not needed though its a comment.
2) every patch line should have some text written in spec about why the
original tarball needed to be patched.
3) Good to add what things got changed from previous release in %changelog
4) In %description, don't put some space for complete sentences like write as
Support for shape-based and phonetic-based input methods,
including those for Chinese dialects.
A selected dictionary in Traditional Chinese,
powered by opencc for Simplified Chinese output.
All other looks good.
APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=BgBu6hlwvX&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
