Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=963339
--- Comment #3 from Björn Esser <bjoern.es...@gmail.com> --- Spec URL: http://besser82.fedorapeople.org/pkg/libyui-bindings/libyui-bindings.spec SRPM URL: http://besser82.fedorapeople.org/pkg/libyui-bindings/libyui-bindings-1.0.1-2.fc18.src.rpm > 1) As I've said before, keep it readable...Orders;No empty line between group > tag and summary tag in subpackages > Fix the BR by remove %global libyui_devel_version %{libname}-devel >= 3.0.3 > with BuildRequires: libyui-devel >= 3.0.3. fixed > BTW is ">= 3.0.3" really required? Nope. Just took that in during c&p from other libyui*.spec 2)Too many %global, just use %{name} with libyui-bindings, why not? It's just two %global (libsuffix = yui and libname = lib%{libsuffix}) besides the obligatory %commit and %shortcommit (lib)yui is used rather often inside the spec. I think spec-file should be easy adoptable for other similar purpose, without doing lots of search-replace, just changing libsuffix to what's needed, then. BTW: In the other libyui*-spec I have similar %global..., so I want keep this consistent. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fXEX8ZjPYg&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
