Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=956669

Antonio Trande <anto.tra...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anto.tra...@gmail.com
              Flags|                            |needinfo+

--- Comment #2 from Antonio Trande <anto.tra...@gmail.com> ---
Hi Christopher.
Just some initial comments:

- I see some changes about FHS fixes. In my opinion, with a single modification
into 'deployment.pri' file, you can resolve all at one time ;)

- .desktop file is already in the source archive; why do you add another one as
Source1 ?

- %{_datadir}/%{name} directory must be owned by the package

- In erebus_source.txt file, the developer says:

>The source code is released under the GPL v3 or later.
>Please contact me if you have suggestions, bug fixes or whatever: mark dot 
>harman >at ntlworld dot com .

I don't see any license file included, apart from docs/gpl.txt file that is not
the GPLv3+ text file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=eiKzw65q7Z&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to