https://bugzilla.redhat.com/show_bug.cgi?id=924377
Hans de Goede <hdego...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |fedora-review?
--- Comment #9 from Hans de Goede <hdego...@redhat.com> ---
Full review done, results:
Good:
====
- rpmlint checks return:
mate-user-share.x86_64: W: non-conffile-in-etc
/etc/xdg/autostart/mate-user-share.desktop
3 packages and 0 specfiles checked; 0 errors, 1 warnings.
This warning can be ignored
- package meets naming guidelines
- package meets packaging guidelines
- license (GPLv2+) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- .desktop file properly validated
Needs work:
========
- You're using an upstream tarbal, so there should be no need to run
autogen.sh, if there is a specific reason for this, please add a comment to the
specfile why you're running autogen.sh. Note that %configure has been modified
in newer redhat-rpm-config versions to take care of aarch64 issues, so if that
is the reason you can drop the autogen.sh call.
- desktop-file-validate is usually called from %install, %check is intended for
packages with come with test-suites to run the test-suite. ie make test / make
check
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=bSEhTa3xiH&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
