https://bugzilla.redhat.com/show_bug.cgi?id=963604

Parag AN(पराग) <panem...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panem...@gmail.com
           Assignee|nob...@fedoraproject.org    |panem...@gmail.com
              Flags|                            |fedora-review+

--- Comment #1 from Parag AN(पराग) <panem...@gmail.com> ---
Review:

+ mock build succeeded for rawhide

+ rpmlint on rpms gave
python-pdfrw.noarch: W: spelling-error %description -l en_US reportlab ->
report lab, report-lab, reportorial
python-pdfrw.src: W: spelling-error %description -l en_US reportlab -> report
lab, report-lab, reportorial
python-pdfrw.src: W: invalid-url Source0:
http://pdfrw.googlecode.com/files/pdfrw_0.1.zip HTTP Error 404: Not Found
2 packages and 0 specfiles checked; 0 errors, 3 warnings.

+ Source verified with upstream as 
http://pdfrw.googlecode.com/files/pdfrw_0.1.zip :
  CHECKSUM(SHA256) this package     :
4dbb4017b179f1ecee947501d178a90e1ff0aaf6444ef24b5a630ee68e884919
  CHECKSUM(SHA256) upstream package :
4dbb4017b179f1ecee947501d178a90e1ff0aaf6444ef24b5a630ee68e884919

+ Package follows packaging guidelines.

suggestions:
1) you don't need following in %install in spec now for Fedora branches.
rm -rf %{buildroot}

2) See if you can package examples directory as %docs but this will make
rpmlint to complain doc-file-dependency warning which can be fixed by 
sed -i '1d' <required files to be removed /usr/bin/env>


APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=ADUteUhwIX&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to